Skip to content

Fix DeepSeek Svelte live submit assertion#342

Open
abdulwahabone wants to merge 1 commit into
pbakaus:mainfrom
abdulwahabone:codex/issue-340-deepseek-submit-assertion
Open

Fix DeepSeek Svelte live submit assertion#342
abdulwahabone wants to merge 1 commit into
pbakaus:mainfrom
abdulwahabone:codex/issue-340-deepseek-submit-assertion

Conversation

@abdulwahabone

@abdulwahabone abdulwahabone commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the DeepSeek Svelte live test to assert the icon-only submit control by aria-label.
  • Remove the stale dependency on visible Go text.

Validation

  • bun run test:live-svelte-adapter-deepseek
  • git diff --check

Fixes #340


Note

Low Risk
Test-only assertion change; no production or runtime behavior is modified.

Overview
Updates assertSelectedElementChrome in the DeepSeek Svelte live adapter test so it matches the icon-only configure-row submit control.

Instead of requiring visible Go text in the live bar, the check now looks for a bar button whose aria-label is Generate variants, consistent with clickGo in tests/live-e2e/ui.mjs.

Reviewed by Cursor Bugbot for commit 865567b. Bugbot is set up for automated code reviews on this repo. Configure here.

@abdulwahabone abdulwahabone marked this pull request as ready for review July 5, 2026 06:58
@abdulwahabone abdulwahabone requested a review from pbakaus as a code owner July 5, 2026 06:58
@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the DeepSeek Svelte live test to use the submit button's accessible name. The main changes are:

  • Replaces the stale visible Go text assertion.
  • Checks for the icon-only Generate variants button by aria-label.
  • Keeps the selected-element chrome assertion aligned with the current live UI.

Confidence Score: 5/5

Safe to merge with minimal risk.

The change is a focused test assertion update, and the new aria-label matches the live UI implementation and existing live E2E helper convention for icon-only submit buttons.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • Reviewed the contract-validation proof showing the environment check failed because the DEEPSEEK_API_KEY is not set, with exit code 1.
  • Observed the live test blocker log confirming the test invocation exits with an error due to DEEPSEEK_API_KEY being required.
  • Verified the diff check log shows git diff --check exited 0, indicating no outstanding diffs.
  • Linked the three uploaded artifact logs to the review to support the environment failure, the test-blocker failure, and the diff status.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
tests/live-svelte-adapter-deepseek.test.mjs Updates the DeepSeek Svelte live assertion to locate the icon-only generate control by its stable aria-label instead of stale visible text; no issues found.

Reviews (1): Last reviewed commit: "Fix DeepSeek Svelte live submit assertio..." | Re-trigger Greptile

@abdulwahabone abdulwahabone changed the title [codex] Fix DeepSeek Svelte live submit assertion Fix DeepSeek Svelte live submit assertion Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeepSeek Svelte live adapter test fails after successful steer

1 participant