cargo-pgrx: add --valgrind flag to cargo pgrx regress - #2290
Merged
eeeebbbbrrrr merged 1 commit intoMay 31, 2026
Merged
Conversation
`cargo pgrx start` and `cargo pgrx run` already accept `--valgrind` and the underlying `start_postgres` already knows how to launch Postgres under valgrind, but the flag was not exposed on `cargo pgrx regress`: `From<&Regress> for Run` hardcoded `valgrind: false`, so there was no way to run the regression suite under valgrind without manually starting Postgres first. This adds the flag to `Regress` and propagates it through to `Run`.
Contributor
Author
|
The "verify package can build / ubuntu" run will be fixed once #2292 is merged |
eeeebbbbrrrr
approved these changes
May 31, 2026
eeeebbbbrrrr
merged commit May 31, 2026
2cd0d14
into
pgcentralfoundation:develop
14 of 15 checks passed
eeeebbbbrrrr
added a commit
that referenced
this pull request
May 31, 2026
Welcome to pgrx v0.18.1. This is a minor release but fixes important build problems on aarch64 Linux introduced in v0.18.0. As always, install the cli tool with `cargo install cargo-pgrx --version 0.18.1 --locked` and make sure to update your extension's to depend on `=0.18.1`. ## What's Changed * upgrade dependencies, including moving rust to 1.96.0 by @eeeebbbbrrrr in #2296 * cargo-pgrx: inject `-Wl,--no-gc-sections` to keep `.pgrxsc` sections on aarch64 Linux by @eeeebbbbrrrr in #2280 * feat: include `rewrite/rewriteManip.h` by @isdaniel in #2295 * Use `zip` instead of deprecated `zip-extract` by @cbandy in #2294 (also by @Natureshadow) * cargo-pgrx: add `--valgrind` flag to `cargo pgrx regress` by @philippemnoel in #2290 * cargo-pgrx: build Postgres in parallel during `cargo pgrx init` by @philippemnoel in #2291 * ci: pass `--locked` to `cargo install --path cargo-pgrx` by @philippemnoel in #2292 * Fix README version range inconsistency (17 → 18) by @hobostay in #2287 * fix: don't allocate for static strings in `ereport!` by @gruuya in #2282 * can `cargo clippy --allow-dirty --fix -- -Wclippy::use_self` by @adamnemecek in #2283 * feature: teach `cargo pgrx schema` how to emit just the SQL for named entities by @eeeebbbbrrrr in #2293 * Fix "PostgresSQL" typo to "PostgreSQL" in test code by @hobostay in #2286 ## New Contributors * @hobostay made their first contribution in #2287 * @adamnemecek made their first contribution in #2283 * @Natureshadow **Full Changelog**: v0.18.0...v0.18.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo pgrx startandcargo pgrx runalready accept--valgrind, and the underlyingstart_postgresalready knows how to launch Postgres under valgrind. But the flag was not exposed oncargo pgrx regress—From<&Regress> for Runhardcodedvalgrind: false, so there was no way to run the regression suite under valgrind without manually starting Postgres beforehand.This adds
--valgrindtoRegressand propagates it through toRun. No new mechanism — just plumbing.Test plan
cargo check -p cargo-pgrxpassescargo pgrx regress --helpshows the new--valgrindflagcargo pgrx regress --valgrindruns the regression suite under valgrind end-to-end