Skip to content

Create chk_s3_class_strict()#295

Merged
StefanoMezzini merged 8 commits into
mainfrom
create-chk-s3-class-strict
Jun 29, 2026
Merged

Create chk_s3_class_strict()#295
StefanoMezzini merged 8 commits into
mainfrom
create-chk-s3-class-strict

Conversation

@StefanoMezzini

@StefanoMezzini StefanoMezzini commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closes #294.

Checks inherits strictly from S3 class using

is.object(x, class) && # exclude base objects
  !isS4(x) && !inherits(x, "R6") && !inherits(x, "S7_object") # exclude other class types

joethorley
joethorley previously approved these changes Jun 29, 2026
View reviewed changes
@StefanoMezzini
StefanoMezzini force-pushed the create-chk-s3-class-strict branch from d7d48e1 to dde637d Compare June 29, 2026 17:41
@StefanoMezzini

StefanoMezzini commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Not sure why the {R6} tests pass in the no-depends test. None of the packages in Depends depend on {R6}.

@StefanoMezzini
StefanoMezzini merged commit 580d616 into main Jun 29, 2026
11 checks passed
@StefanoMezzini
StefanoMezzini deleted the create-chk-s3-class-strict branch June 29, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joethorley joethorley joethorley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create chk_s3_class_strict()

2 participants

@StefanoMezzini @joethorley