New Adapter: ReVantage#4477
Conversation
Removed detailed class-level documentation and some comments in the makeHttpRequests method.
| public void makeBidsShouldReturnEmptyListOn204() throws Exception { | ||
| // given | ||
| final BidderCall<BidRequest> httpCall = givenHttpCall(204, null); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, BidRequest.builder().build()); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()).isEmpty(); | ||
| } |
There was a problem hiding this comment.
As null is expected in the body, maybe it would make sense to first check if it's not null, since this test, doesn't seem to pass.
Also can the body of the response be null when makeBids is called? Would expect for it to be an empty string "".
@CTMBNara what do you think?
| } | ||
|
|
||
| @Test | ||
| public void makeBidsShouldDetectVideoFromVastWhenMtypeAbsent() throws Exception { |
There was a problem hiding this comment.
nitpick
I would suggest to add a test cases for the adm that starts with <?XML and also for the case that adm is empty that it would be marked as an mtype of banner.
Removed validation annotation from configuration properties bean.
|
Please let me know if anything else has been missed or if we're good to go |
|
Any Info on a merge? |
|
@v0idxyz currently, PBS is on hold for adapter merges. The main focus is the next major update, 4.0, which should be finished by the end of Q2. Once that is done, we should be unblocked for merging other PRs. Sorry for the inconvenience |
Does this affect only PBS Java or PBS Go aswell? |
4 participants
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check