fix(registry): prevent file descriptor leak in WriteToTextfile#2010
Merged
Conversation
In WriteToTextfile, if an error occurs before the explicit tmp.Close() (e.g., Gather fails or MetricFamilyToText fails), the temporary file descriptor is never closed. The deferred os.Remove(tmp.Name()) does not close the file. Explicitly close the file on all error paths that happen before the final close, ensuring the descriptor is always released. Additionally, this fixes the issue on Windows where an open file cannot be deleted, preventing the deferred os.Remove from succeeding. Fixes: 1d54dab ("Add WriteToTextfile test") Found by PostgresPro. Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
ProjectMutilation
requested review from
bwplotka,
kakkoyun and
vesari
as code owners
kakkoyun
approved these changes
Jun 1, 2026
Member
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WriteToTextfile, if an error occurs before the explicit tmp.Close() (e.g., Gather fails or MetricFamilyToText fails), the temporary file descriptor is never closed. The deferred os.Remove(tmp.Name()) does not close the file.
Explicitly close the file on all error paths that happen before the final close, ensuring the descriptor is always released.
Additionally, this fixes the issue on Windows where an open file cannot be deleted, preventing the deferred os.Remove from succeeding.
Fixes: 1d54dab ("Add WriteToTextfile test")
Found by PostgresPro.