Fasttable: Undo gating of decode_fast targets in upb.#27509
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Fasttable: Undo gating of decode_fast targets in upb.#27509copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Targets in //third_party/upb currently gate inclusion of certain targets from //third_party/upb/upb/wire/decode_fast at the dependency and #include level. However, after recent changes, the inclusion should be safe, and functionality should be fully gated behind UPB_ENABLE_FASTTABLE. This CL removes the build-level gating in BUILD files and the #ifdef guards in C/C++ files, making the inclusion unconditional. PiperOrigin-RevId: 919143624
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fasttable: Undo gating of decode_fast targets in upb.
Targets in //third_party/upb currently gate inclusion of certain targets from //third_party/upb/upb/wire/decode_fast at the dependency and #include level. However, after recent changes, the inclusion should be safe, and functionality should be fully gated behind UPB_ENABLE_FASTTABLE.
This CL removes the build-level gating in BUILD files and the #ifdef guards in C/C++ files, making the inclusion unconditional.