Skip to content

feat(aws): add acmpca service and pqc key algorithm check#11318

Open
pedrooot wants to merge 1 commit into
masterfrom
feat/acmpca-certificate-authority-pqc-key-algorithm
Open

feat(aws): add acmpca service and pqc key algorithm check#11318
pedrooot wants to merge 1 commit into
masterfrom
feat/acmpca-certificate-authority-pqc-key-algorithm

Conversation

@pedrooot
Copy link
Copy Markdown
Member

@pedrooot pedrooot commented May 21, 2026

Context

RSA and ECC signatures can be forged by a cryptographically relevant quantum computer. AWS Private CA now supports ML-DSA (NIST FIPS 204), a quantum-resistant signature algorithm, so customers can begin migrating their PKI. Prowler had no AWS Private CA service.

Description

Introduces the AWS Private CA (acmpca) service and the acmpca_certificate_authority_pqc_key_algorithm check. The check evaluates each certificate authority's KeyAlgorithm against a configurable allowlist (acmpca_pqc_key_algorithms, defaults: ML_DSA_44, ML_DSA_65, ML_DSA_87). Deleted CAs are skipped. Severity: low.

Steps to review

  1. New service: prowler/providers/aws/services/acmpca/ (acmpca_service.py, acmpca_client.py)
  2. Check implementation: prowler/providers/aws/services/acmpca/acmpca_certificate_authority_pqc_key_algorithm/
  3. Run the tests: poetry run pytest tests/providers/aws/services/acmpca/ -v
  4. Optionally run against a real environment: prowler aws --check acmpca_certificate_authority_pqc_key_algorithm

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? Yes
    • No new permissions needed: acm-pca:ListCertificateAuthorities/acm-pca:DescribeCertificateAuthority are already covered by the AWS managed SecurityAudit policy.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner May 21, 2026 22:19
@github-actions github-actions Bot added documentation provider/aws Issues/PRs related with the AWS provider metadata-review labels May 21, 2026
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 21, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
prowler 🟢 Ready View Preview May 21, 2026, 10:25 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Compliance Mapping Review

This PR adds new checks. Please verify that they have been mapped to the relevant compliance framework requirements.

New checks not mapped to any compliance framework in this PR

  • acmpca_certificate_authority_pqc_key_algorithm (aws)

Please review whether these checks should be added to compliance framework requirements in prowler/compliance/<provider>/. Each compliance JSON has a Checks array inside each requirement — add the check ID there if it satisfies that requirement.

Use the no-compliance-check label to skip this check.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 2.67%. Comparing base (7d03bc5) to head (82a62d9).
⚠️ Report is 13 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7d03bc5) and HEAD (82a62d9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7d03bc5) HEAD (82a62d9)
api 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11318       +/-   ##
===========================================
- Coverage   93.97%    2.67%   -91.30%     
===========================================
  Files         237      860      +623     
  Lines       34829    25175     -9654     
===========================================
- Hits        32729      674    -32055     
- Misses       2100    24501    +22401     
Flag Coverage Δ
api ?
prowler-py3.10-aws 2.19% <92.98%> (?)
prowler-py3.10-config 2.67% <92.98%> (?)
prowler-py3.11-aws 2.19% <92.98%> (?)
prowler-py3.11-config 2.67% <92.98%> (?)
prowler-py3.12-aws 2.19% <92.98%> (?)
prowler-py3.12-config 2.67% <92.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 2.67% <92.98%> (∅)
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

🔒 Container Security Scan

Image: prowler:4bda636
Last scan: 2026-05-21 22:34:28 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 6
Total 6

5 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@pedrooot pedrooot force-pushed the feat/acmpca-certificate-authority-pqc-key-algorithm branch from 099647f to 82a62d9 Compare May 21, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation metadata-review new-check provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants