Skip to content

test(ui): find scheduled scan e2e row in In Progress tab#11385

Merged
jfagoagas merged 1 commit into
masterfrom
test/fix-e2e
May 29, 2026
Merged

test(ui): find scheduled scan e2e row in In Progress tab#11385
jfagoagas merged 1 commit into
masterfrom
test/fix-e2e

Conversation

@alejandrobailo
Copy link
Copy Markdown
Contributor

Context

The provider E2E tests (PROVIDER-E2E-*) fail in CI on the new tabbed Scan Jobs view. After adding a provider, verifyScheduledScanStatus navigated to the Scheduled tab to find the provider's scan row, but it never appears there.

The tabs filter scans by state, not trigger: Scheduled only shows state=scheduled. When a provider is created, the backend first creates a scheduled-trigger scan in the available state (the immediate first run), which the UI lists under In Progress (available/executing). The pure state=scheduled row (the next run) is created asynchronously and isn't present within the test window. The previous single-table view matched the row regardless of state; the tabbed view filters it out of Scheduled.

No Jira task associated.

Description

  • Point verifyScheduledScanStatus to the In Progress tab (/scans?tab=active) where the freshly created scheduled-trigger scan (state=available) actually appears.
  • Keeps the existing reload + 15s fallback (the reload() preserves the ?tab=active query param).
  • Test-only change; no production code touched.

Steps to review

  1. ui/tests/scans/scans-page.tsverifyScheduledScanStatus: confirm it now calls gotoTab("active") instead of gotoTab("scheduled"), with the comment explaining the AVAILABLE-state reasoning.
  2. Confirm the CI e2e-tests job turns green for the providers project (previously failing at scans-page.ts row lookup).

Checklist

  • Review if the code is being covered by tests.

UI

  • All issue/task requirements work as expected on the UI

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alejandrobailo alejandrobailo requested a review from a team as a code owner May 28, 2026 19:04
@alejandrobailo alejandrobailo added the no-changelog Skip including change in changelog/release notes label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@alejandrobailo alejandrobailo requested a review from jfagoagas May 28, 2026 19:05
@alejandrobailo alejandrobailo self-assigned this May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔒 Container Security Scan

Image: prowler-ui:f6f8039
Last scan: 2026-05-28 19:07:26 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

Copy link
Copy Markdown
Contributor

@pfe-nazaries pfe-nazaries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfagoagas jfagoagas merged commit 02b7135 into master May 29, 2026
28 of 30 checks passed
@jfagoagas jfagoagas deleted the test/fix-e2e branch May 29, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ui no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants