Skip to content

Optimize tracing with C-extension#395

Open
ikaaa2001 wants to merge 1 commit into
pschanely:mainfrom
ikaaa2001:patch-1
Open

Optimize tracing with C-extension#395
ikaaa2001 wants to merge 1 commit into
pschanely:mainfrom
ikaaa2001:patch-1

Conversation

@ikaaa2001
Copy link
Copy Markdown

Updated tracers.py to use the frame_stack_read C extension, reducing overhead for function call tracing.

Updated tracers.py to use the frame_stack_read C extension, reducing overhead for function call tracing.
@ikaaa2001
Copy link
Copy Markdown
Author

I have updated tracers.py to utilize the frame_stack_read function from the C extension. This change optimizes the performance of function tracing by offloading stack reads to C. Ready for review.

@ikaaa2001
Copy link
Copy Markdown
Author

Hi! I see that the CI tests are failing on Python 3.9. Could you please help me understand the error logs so I can fix the compatibility issue? I want to ensure the frame_stack_read logic works correctly across all supported versions.

@pschanely
Copy link
Copy Markdown
Owner

Apologies for taking so long to reply to this!
You have a failure because the code has not been formatted with black - please read and follow https://crosshair.readthedocs.io/en/latest/contributing.html

It also doesn't seem like your changes are doing what you think they are? These code sections are already using frame_stack_read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants