revert: "add life support to handles cast to string_view (#6092)"#6097
Merged
Conversation
rwgk
approved these changes
Jun 29, 2026
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Jun 29, 2026
…ind#6092)" This re-applies pybind#6092 (reverting pybind#6097) so the follow-up fixes in this PR can build on it. Assisted-by: ClaudeCode:claude-opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Reverts #6092.
#6092 ("add life support to handles cast to string_view") introduced regressions that are being addressed in #6096. Reverting it here so
masteris clean while the proper fix is worked out.This is a clean revert of 59d7cb2 — it removes the
loader_life_support::add_patient(src)calls added tostring_casterand the accompanyingfunc_with_string_viewstest.Suggested changelog entry
Reverted #6092 (string_view life support), which introduced regressions.