Fix .pyi stubs being shadowed by compiled modules in get_source_file#3099
Open
czinck wants to merge 2 commits into
Open
Fix .pyi stubs being shadowed by compiled modules in get_source_file#3099czinck wants to merge 2 commits into
czinck wants to merge 2 commits into
Conversation
PR pylint-dev#2722 generalized ``get_source_file`` from "if handed a .pyi, return it" to "if handed any non-source extension, return it as-is". Unfortunately, that also matched compiled bytecode (.pyc/.pyo) and binary extension modules (.so/.pyd/.dll): when import machinery handed in a ``.pyc`` that had a ``.pyi`` stub beside it, the ``.pyc`` was returned and then parsed as source, failing with "wrong encoding". Exclude bytecode and binary-extension suffixes from that branch so they fall through to the normal stub/source lookup. The existing non-standard-extension behavior (custom suffixes like ``.weird_ext``) is unchanged. Closes pylint-dev#3087
for more information, see https://pre-commit.ci
Merging this PR will not alter performance
Comparing 
Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3099 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 92 92
Lines 11364 11367 +3
=======================================
+ Hits 10637 10640 +3
Misses 727 727
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
#2722 generalized
get_source_filefrom "if handed a .pyi, return it" to "if handed any non-source extension, return it as-is". Unfortunately, that also matched compiled bytecode (.pyc/.pyo) and binary extension modules (.so/.pyd/.dll): when import machinery handed in a.pycthat had a.pyistub beside it, the.pycwas returned and then parsed as source, failing with "wrong encoding".Exclude bytecode and binary-extension suffixes from that branch so they fall through to the normal stub/source lookup. The existing non-standard-extension behavior (custom suffixes like
.weird_ext) is unchanged.Closes #3087