Remove deprecated setup_any_logging function#3788
Open
suhailnasar wants to merge 1 commit into
Open
Conversation
Collaborator
|
@vfdev-5 Is the next release going to be 0.6.0 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup_any_loggingwas deprecated in version 0.4.0 and scheduled forremoval in 0.6.0. Since we are now at 0.6.0, this PR removes the function
and its corresponding test.
Changes
setup_any_loggingfunction fromignite/contrib/engines/common.pydeprecatedimport fromignite/contrib/engines/common.pytest_deprecated_setup_any_loggingtest fromtests/ignite/contrib/handlers/test_logger_utils.py