Change reader and component names from "VII" to "METimage" and fix minor issues#3395
Open
ameraner wants to merge 17 commits into
Open
Change reader and component names from "VII" to "METimage" and fix minor issues#3395ameraner wants to merge 17 commits into
ameraner wants to merge 17 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3395 +/- ##
==========================================
- Coverage 96.32% 96.32% -0.01%
==========================================
Files 466 464 -2
Lines 59096 59081 -15
==========================================
- Hits 56922 56907 -15
Misses 2174 2174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
vii_l1b_ncandvii_l2_nctometimage_l1b_ncandmetimage_l2_nc. The old reader names are put in deprecation (they still work but emit a FutureWarning). The python files and class names are adapted accordingly.On top, two minor fixes are also implemented:
... and the
rows_per_scanattribute is added to datasets to support EWA resampling.FYI @cesclc @TAlonglong @ludwigVonKoopa