Skip to content

expose concave hull of polygons & fill gaps between polygons alg#11081

Open
hefniraera wants to merge 1 commit into
qgis:masterfrom
hefniraera:poly-concavehull
Open

expose concave hull of polygons & fill gaps between polygons alg#11081
hefniraera wants to merge 1 commit into
qgis:masterfrom
hefniraera:poly-concavehull

Conversation

@hefniraera

Copy link
Copy Markdown
Collaborator

fixes #10886

Goal:

Ticket(s): #

  • Backport to LTR documentation is requested

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more space between the different scenarios to help distinguish the different groups? And instead of reading from top to bottom, what about organizing the images from left to right, i.e. rotate -90°.

Question: the feature in the middle has a hole, right? A hole whose vertices touch the outer ring of the polygon? Is this valid?

.. figure:: img/fill_gaps_between_polygons.png
:align: center

Filling gaps between polygons using ratio values of 0, 0.3 and 1.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested above, turn the images -90°?
And instead of ratio of 0, can we consider the first group as "input features". The ratio=0 output would have had blue hash above, right?

The algorithm works by creating a constrained Delaunay Triangulation of the space between
the polygons and removing the longest outer edges until a target criterion is reached.

The input geometry must be a valid Polygon or MultiPolygon (i.e., the individual polygons must not overlap).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this sentence is taken from the GUI but something makes me uncomfortable with it:

  • "a valid polygon": is it about individual parts of the expected multipolygon or are single polygons also allowed inputs?
  • individual polygons within the same multipolygons shouldn't overlap?
  • individual polygons from two different multipolygons shouldn't overlap?

Concave hulls by feature


.. seealso:: :ref:`qgisconvexhull`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to (cross)link to more concave hull algorithms

Comment on lines +1304 to 1305
- [vector: geometry]
- Input vector layer with multipoint features

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to review this description as well as the algorithm description. They are outdated because of focusing on multipoint input fetures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose concave hull of polygons functionality (Request in QGIS)

2 participants