-
Notifications
You must be signed in to change notification settings - Fork 14
feat: add multi-url failover to Python bindings #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nwoolmer
wants to merge
5
commits into
main
Choose a base branch
from
feat/multi-url-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f796526
feat: add multi-url failover support to Python bindings
nwoolmer ce13b3a
fix: review round 2 — test hardening and coverage
nwoolmer 5ed6564
fix: widen addresses type stub to Sequence[Sequence[...]]
nwoolmer 7f94223
fix: validate address host type, improve error messages
nwoolmer 8289d73
chore: update c-questdb-client submodule
nwoolmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule c-questdb-client
updated
12 files
| +1 −1 | ci/run_all_tests.py | |
| +15 −0 | include/questdb/ingress/line_sender.h | |
| +13 −0 | include/questdb/ingress/line_sender.hpp | |
| +2 −6 | questdb-rs-ffi/Cargo.lock | |
| +1 −1 | questdb-rs-ffi/Cargo.toml | |
| +16 −0 | questdb-rs-ffi/src/lib.rs | |
| +1 −1 | questdb-rs/Cargo.toml | |
| +177 −51 | questdb-rs/src/ingress/mod.rs | |
| +178 −44 | questdb-rs/src/ingress/sender/http.rs | |
| +12 −5 | questdb-rs/src/ingress/sender/mod.rs | |
| +415 −8 | questdb-rs/src/ingress/tests.rs | |
| +981 −1 | questdb-rs/src/tests/http.rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is currently a no-op.
sender.row(..., at=TimestampNanos.now())does not write anything unless at least one symbol or column is present, so this path just rewinds the buffer insrc/questdb/ingress.pyx. With no assertion afterwards, the test stays green even if timestamp-only writes are unsupported or broken. Please either assert the no-op explicitly or add a real field and verify the row was persisted.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pre-existing code, not introduced by this PR — out of scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nwoolmer, the diff actually shows this test was added in this PR — all four lines carry+markers, indicating they are new additions. The AI-generated summary also confirms it: "Added new test methodtest_sending_just_timestampsto send a row with only a timestamp."Given that, the concern stands: as written the test is effectively a no-op (no column/symbol → nothing is written → no assertion). Would you like to either: