fix(containerImages): restrict local build contexts - #238
Draft
AzureMike wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Mike Azure <mikeazure+microsoft@microsoft.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restricts local container image build contexts to
/var/radius/build-contexts. This prevents builds from accessing registry credentials in the Terraform working directory.Git build sources are unchanged.
Fixes #231
Question
@willdavsmith, should we address this, or is the current behavior acceptable? The issue only affects local builds, but a developer who controls the build context and Dockerfile can copy files available to
dynamic-rp, including registry credentials.Pros: Local builds can only access files the platform engineer places under
/var/radius/build-contexts. Git builds are unchanged.Cons: I think the Radius Helm chart cannot mount this directory through its values today. Local builds would require a custom chart or Deployment patch, plus a volume containing the source. Existing local paths outside this directory will stop working.