Make RabbitMQ password optional - #295
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Radius.Messaging/rabbitMQ resource type to treat the broker password as optional, and adds a minimal Radius application model under .radius/ intended to support tooling (e.g., graph generation / compilation).
Changes:
- Marked
passwordas optional in the RabbitMQ schema by removing it fromrequired. - Updated RabbitMQ resource documentation to label
passwordas optional. - Added
.radius/app.bicepas a minimal sample app model that provisions a RabbitMQ broker and a backingRadius.Security/secretsresource.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Messaging/rabbitMQ/README.md | Updates the properties table to mark password as optional. |
| Messaging/rabbitMQ/rabbitMQ.yaml | Removes password from the schema required list and updates its description accordingly. |
| .radius/app.bicep | Adds a small Radius app model that deploys a RabbitMQ broker + secrets resource. |
Suppressed comments (1)
Messaging/rabbitMQ/rabbitMQ.yaml:93
- The schema no longer requires
password, but the Kubernetes recipe depends on it being present. This allows invalid resources to pass schema validation and then fail during deployment.
required: [environment]
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
DariuszPorowski
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passwordan optionalRadius.Security/secretsresource ID forRadius.Messaging/rabbitMQ.Radius.Security/secretsresource.Validation