Skip to content

Make RabbitMQ password optional - #295

Merged
DariuszPorowski merged 8 commits into
mainfrom
sk593-rabbitmq-optional-password
Aug 14, 2026
Merged

Make RabbitMQ password optional#295
DariuszPorowski merged 8 commits into
mainfrom
sk593-rabbitmq-optional-password

Conversation

@sk593

@sk593 sk593 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Make password an optional Radius.Security/secrets resource ID for Radius.Messaging/rabbitMQ.
  • Reuse the supplied secret directly when present.
  • When absent, generate a random fallback, create broker credentials, and return the value through a managed Radius.Security/secrets resource.
  • Update the test application to exercise the fallback path.

Validation

  • Parsed and validated the RabbitMQ resource type YAML.
  • Compiled the Kubernetes Recipe and test application with the Radius Bicep compiler.

sk593 and others added 2 commits August 14, 2026 11:11
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
@sk593
sk593 requested a review from a team as a code owner August 14, 2026 18:12
Copilot AI lite review requested due to automatic review settings August 14, 2026 18:12
@sk593
sk593 requested a review from a team as a code owner August 14, 2026 18:12
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Radius.Messaging/rabbitMQ resource type to treat the broker password as optional, and adds a minimal Radius application model under .radius/ intended to support tooling (e.g., graph generation / compilation).

Changes:

  • Marked password as optional in the RabbitMQ schema by removing it from required.
  • Updated RabbitMQ resource documentation to label password as optional.
  • Added .radius/app.bicep as a minimal sample app model that provisions a RabbitMQ broker and a backing Radius.Security/secrets resource.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
Messaging/rabbitMQ/README.md Updates the properties table to mark password as optional.
Messaging/rabbitMQ/rabbitMQ.yaml Removes password from the schema required list and updates its description accordingly.
.radius/app.bicep Adds a small Radius app model that deploys a RabbitMQ broker + secrets resource.
Suppressed comments (1)

Messaging/rabbitMQ/rabbitMQ.yaml:93

  • The schema no longer requires password, but the Kubernetes recipe depends on it being present. This allows invalid resources to pass schema validation and then fail during deployment.
          required: [environment]

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Messaging/rabbitMQ/README.md Outdated
Comment thread Messaging/rabbitMQ/rabbitMQ.yaml Outdated
sk593 and others added 5 commits August 14, 2026 11:20
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
@DariuszPorowski
DariuszPorowski merged commit ebdeec9 into main Aug 14, 2026
13 checks passed
@DariuszPorowski
DariuszPorowski deleted the sk593-rabbitmq-optional-password branch August 14, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants