fix: upgrade workflows, example modules, and test harnesses#2277
Open
matttrach wants to merge 1 commit into
Open
fix: upgrade workflows, example modules, and test harnesses#2277matttrach wants to merge 1 commit into
matttrach wants to merge 1 commit into
Conversation
Signed-off-by: matttrach <matt.trachier@suse.com>
matttrach
added
the
internal/ignore
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refreshes the CI/CD pipeline and test harness around the Terraform provider. It bumps Go (1.24.5 → 1.26.3), upgrades terratest to v1.0.0 (renaming Get*/*E calls to their Context variants and SshAgent → SSHAgent), updates the AWS SDK and other transitive deps, refreshes the example modules to newer chart/cert-manager versions and the tar install method, and significantly hardens the workflows (least-privilege permissions, SHA-pinned actions, extracted github-script logic into reusable JS files, split release-please into release-only and PR-only jobs, added timeouts and concurrency).
Changes:
- Bump test-harness Go module deps and adopt
t.Context()+*Context*Eterratest APIs. - Rework
release.ymlinto release-please-release / release-please-pr / wait-for-e2e and extract severalgithub-scriptblocks into.github/workflows/scripts/*.js. - Refresh example modules (cert-manager 1.20.2, helm provider ≥3.1.1, rancher/aws/rancher2 3.1.4,
tarinstall method, generated admin password) and thecleanup.shRoute 53 sweep.
Reviewed changes
Copilot reviewed 39 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/util.go, test/{one,three,production}/basic_test.go, test/config/config.go | Switch to terratest *Context* APIs and renamed SSHAgent/UniqueID. |
| test/go.mod, test/go.sum | Bump terratest, AWS SDK, and transitive deps; bump go directive to 1.26.3. |
| test/.golangci.yml | New v2 golangci config for the test module. |
| run_tests.sh | Drop -d/dirty mode, simplify TEST_DIR detection, always run cleanup. |
| GNUmakefile, README.md, flake.nix, flake.lock | Add lint-tests/lint-workflows, update Go version docs, refresh nix shell packages. |
| release-please-config.json, .goreleaser.yml | Bump to v15, switch to draft-based release flow. |
| examples/use-cases/{one,three,production}/{main,versions}.tf | Newer chart/provider versions, lowercased domains, tar install method, generated admin password. |
| cleanup.sh | Add Route 53 record sweep step. |
| .github/workflows/.yml, .github/workflows/scripts/.js | Add explicit permissions/timeouts, SHA-pin actions, extract reusable github-script logic, split release-please jobs. |
| .github/pull_request_template.md, .github/instructions/workflows.instructions.md | Doc/template tweaks. |
| export ACME_SERVER_URL="https://acme-v02.api.letsencrypt.org/directory" | ||
| export RANCHER_INSECURE="false" | ||
| ./run_tests.sh -t ${{matrix.test_name}} -d | ||
| ./run_tests.sh -t "$TEST_NAME" -d |
| cd .github/workflows/scripts && \ | ||
| while read -r file; do node --check "$$file"; done <<<"$$(find . -type f \( -name "*.js" \))" | ||
|
|
||
| .PHONY: fmt lint build install generate test testacc dt et clean lint-workflows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change upgrades all workflow actions, the example modules, and the Go packages in the test harness.
Testing
actionlint, e2e test pass
This updates testing and workflows, no change to the product itself.
Not a breaking change.