[1/N][History server] History server to hold on to list of ClusterInfo#4856
Draft
chiayi wants to merge 1 commit into
Draft
[1/N][History server] History server to hold on to list of ClusterInfo#4856chiayi wants to merge 1 commit into
chiayi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is part of updating log directory to:
Since
OwnerKindandOwnerNamewill be required, history server will have to hold on to the clusterInfo in order to know what cookies to add.History server will hold on to a map of clusterInfo when
clusters/is called.enter_cluster/will check if the user input exists in the map.Related issue number
Part of #4708
Next PR will be the updating the log directory structure (different PR since I think it will be too big).
Checks