Skip to content

Proper support for remove_depends=False #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gsakkis wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Proper support for remove_depends=False #490

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4f8550
Run mypy on integrations.base and fix typing issues
gsakkis Jun 22, 2025
e30aaab
DRYfy the _get_auto_injected_* functions
gsakkis Jun 22, 2025
f504589
Allow passing explicitly the dependencies when remove_depends=False
gsakkis Jun 22, 2025
76317d4
Unignore COM812
gsakkis Jun 23, 2025
8ea2d9c
Optimize the remove_depends=True path
gsakkis Jun 23, 2025
6327e8c
Remove asyncio.gather()
gsakkis Jun 24, 2025
cd21328
More optimization and refactoring: replace _iter_dependencies_to_inje…
gsakkis Jun 24, 2025
c161f7b
More remove_depends=True path optimization: just an extra isinstance(…
gsakkis Jun 24, 2025
1a1eea0
Replace list comprehensions with normal loops
gsakkis Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
[mypy]
files = src/dishka
exclude = ^src/dishka/(_adaptix|integrations)/
exclude = (?x)(
^src/dishka/_adaptix/
|^src/dishka/integrations/(
aiohttp
|aiogram
|celery
|click
|fastapi
|faststream
|grpcio
|litestar
|sanic
|starlette
|taskiq
|telebot
).py)

strict = true
strict_bytes = true
Expand Down
1 change: 1 addition & 0 deletions .ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ lint.ignore = [
"PLR0913",
"SIM103",
"ISC003",
"COM812",
Comment thread
gsakkis marked this conversation as resolved.
Outdated

# identitcal by code != identical by meaning
"SIM114",
Expand Down
Loading
Loading