Skip to content

fix: restore Add to favorites on GitOps detail pages #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aali309 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: restore Add to favorites on GitOps detail pages #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b30666
fix: restore Add to favorites on GitOps detail pages
aali309 May 22, 2026
001cce7
fix: restore Add to favorites on GitOps detail pages
aali309 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/gitops/components/shared/FavoriteButton/FavoriteButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from '@patternfly/react-core';
import { ModalVariant } from '@patternfly/react-core/deprecated';
import { Modal as PfModal, ModalProps as PfModalProps } from '@patternfly/react-core/deprecated';
import { StarIcon } from '@patternfly/react-icons';
import { OutlinedStarIcon, StarIcon } from '@patternfly/react-icons';

import { useUserSettingsCompatibility } from './useUserSettingsCompatibility';

Expand All @@ -34,7 +34,9 @@ const Modal: React.FC<ModalProps> = ({ isFullScreen = false, className, ...props
<PfModal
{...props}
className={cx('ocs-modal', className)}
appendTo={() => (isFullScreen ? document.body : document.querySelector('#modal-container'))}
appendTo={() =>
isFullScreen ? document.body : document.querySelector('#modal-container') ?? document.body
}
/>
);

Expand Down Expand Up @@ -101,7 +103,8 @@ export const FavoriteButton = ({ defaultName }: FavoriteButtonProps) => {
setIsModalOpen(false);
};

const handleConfirmStar = () => {
const handleConfirmStar = (e?: React.FormEvent) => {
e?.preventDefault();
const trimmedName = name.trim();
if (!trimmedName) {
setError(t('Name is required.'));
Expand Down Expand Up @@ -157,7 +160,7 @@ export const FavoriteButton = ({ defaultName }: FavoriteButtonProps) => {
<div className="co-fav-actions-icon">
<Tooltip content={tooltipText} position="top">
<Button
icon={<StarIcon color={isStarred ? 'gold' : 'gray'} />}
icon={isStarred ? <StarIcon color="gold" /> : <OutlinedStarIcon />}
className="co-xl-icon-button"
data-test="favorite-button"
variant="plain"
Expand Down Expand Up @@ -188,10 +191,10 @@ export const FavoriteButton = ({ defaultName }: FavoriteButtonProps) => {
]}
variant={ModalVariant.small}
>
<Form id="confirm-favorite-form" onSubmit={handleConfirmStar}>
<Form id="confirm-favorite" onSubmit={handleConfirmStar}>
<FormGroup label={t('Name')} isRequired fieldId="input-name">
<TextInput
id="confirm-favorite-form-name"
id="input-name"
data-test="input-name"
name="name"
type="text"
Expand Down