feat: benchmark F9/F10 document structure and code lens refresh push (issue #256)#261
Merged
Merged
Conversation
Issue #256: reviewed the two benchmark suites against the LSP feature inventory and found three gaps. - Document Outline (F9) and Folding Range (F10) fire on every keystroke burst but had no isolated P95 measurement in the interactive `run` suite — only touched incidentally under the session suite's contention, with no dedicated warm-up/measured window. Adds DocumentSymbolAsync/ FoldingRangeAsync scenarios using the harness's existing RequestDocumentSymbolAsync/RequestFoldingRangeAsync. - workspace/codeLens/refresh had no batch coverage, unlike its two structural siblings (semanticTokens/refresh, inlayHint/refresh), which were both already benchmarked — an inconsistency rather than a deliberate omission. Unlike those two it isn't triggered by a plain .feature edit (BindingRegistryChangedHandler only requests it after an incremental Roslyn patch), so CodeLensRefreshAsync reuses RoslynReDiscoveryAsync's synthetic .cs binding edit and waits for the refresh push instead. Verified by running the benchmark binary directly: all three new rows report real numbers (textDocument/documentSymbol, textDocument/foldingRange, workspace/codeLens/refresh). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #256
Summary
Reviewed the two benchmark suites against the LSP feature inventory (#256) and found three gaps:
runsuite — only touched incidentally under the session suite's contention, with no dedicated warm-up/measured window. AddsDocumentSymbolAsync/FoldingRangeAsyncscenarios using the harness's existingRequestDocumentSymbolAsync/RequestFoldingRangeAsync.workspace/codeLens/refreshhad no batch coverage, unlike its two structural siblings (semanticTokens/refresh,inlayHint/refresh), which were both already benchmarked — an inconsistency rather than a deliberate omission. Unlike those two it isn't triggered by a plain.featureedit (BindingRegistryChangedHandleronly requests it after an incremental Roslyn patch), soCodeLensRefreshAsyncreusesRoslynReDiscoveryAsync's synthetic.csbinding edit and waits for the refresh push instead.The issue's own example (Inlay Hints) turned out not to be a gap — already benchmarked both interactively and as a refresh scenario, so it isn't touched here.
Test plan
dotnet build Reqnroll.IdeSupport.slnx— cleandotnet Reqnroll.IdeSupport.LSP.Server.Benchmarks.dll run --warmup 1 --iterations 3 --files 3) — all three new rows report real numbers:textDocument/documentSymbol,textDocument/foldingRange,workspace/codeLens/refresh🤖 Generated with Claude Code