Skip to content

graphPeaks (recreate PR after merging)#23

Closed
tnaake wants to merge 25 commits into
rformassspectrometry:develfrom
tnaake:graphPeaks
Closed

graphPeaks (recreate PR after merging)#23
tnaake wants to merge 25 commits into
rformassspectrometry:develfrom
tnaake:graphPeaks

Conversation

@tnaake
Copy link
Copy Markdown
Collaborator

@tnaake tnaake commented Oct 14, 2019

As written here, here is the new PR against the devel branch for the graphPeaks function.

tnaake added 25 commits August 29, 2019 11:08
@sgibb sgibb self-requested a review October 14, 2019 11:50
@sgibb sgibb self-assigned this Oct 14, 2019
@sgibb sgibb added the enhancement New feature or request label Oct 14, 2019
@jorainer
Copy link
Copy Markdown
Member

I really like the functionality that you add here, only, I think we have to fix this PR. I don't know what would be best, closing this PR, try to sync your branch to the master (no longer the devel branch) and create it again? @sgibb any suggestions?

@sgibb sgibb mentioned this pull request Oct 25, 2019
@sgibb
Copy link
Copy Markdown
Member

sgibb commented Oct 25, 2019

Closing this in favour of #25. @tnaake thanks for your contribution please find an explanation in my PR.

@sgibb sgibb closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants