Add default charge up to precursor charge in plotSpectraPTM#44
Merged
Conversation
There was an error because I changed the USI source for charge which should be the precursorCharge by default in a spectra object.
lgatto
reviewed
May 8, 2026
Collaborator
Author
|
I have made a couple changes:
Either way, the default options are most likely going to be used: all fragments with charge states |
Collaborator
Author
|
And I added the PSMatch logo to thje README for better visibility |
lgatto
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a discussion with @lgatto, we thought it would be interesting to include a charge parameter in
plotSpectraPTM.By default, the charge used to be set to 1, which missed quite a few fragments when the charge state of the precursor ion is higher than 2. Thus instead of having to manually include the charge state, a simple (big !) improvement is to set the default charge state a spectrum instance to be
1:precursorCharge(x).It does make a huge difference and it integrates well with the variable modifications by allowing a list (or not) of charge values passed to
labelFragments(). I believe this is the most straight-forward way to include the charge state in the spectra.I bumped the version to 1.17.1 since there has been a devel update and I updated the NEWS