fix: Adjust amendment retired/obsolete status#1331
Open
pdp2121 wants to merge 1 commit into
Open
Conversation
pdp2121
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR from VHS introduced retired/obsolete statuses for amendments instead of a single deprecated stanza. Distinction: Retired amendments were enabled long ago and are now permanently baked into the protocol (rippled removed their pre-amendment code), whereas obsolete amendments were never enabled and never will be — they were superseded, pulled, or dropped before ever passing.
This PR will reflect the change in amendments table.
Context of Change
Type of Change
Test Plan
Verified on dev with new v3.2.0 retirements:
https://livenet.dev.ripplex.io/amendments