fix(adblock): hide empty leaderboard and upgrade menu item - #171
Conversation
|
but the blank strip on the playlists page appear only when script didn't load fast enough when installed via marketplace. If you will use adblockify locally it will never appear. |
|
Ah, I didn’t know the Marketplace version could load late — that explains why I could reproduce the blank strip there but not with a local install. Thanks for clarifying. I still think collapsing the empty wrapper is a harmless fallback for that timing case, while the upgrade-menu fix is independent. If you’d prefer, I can split the changes or keep only the menu fix. |
|
I would prefer if the css would not use any selectors since they're "slow" though |
|
Yeah, fair — I assume you mean the new |
On recent Spotify builds the leaderboard ad itself is hidden, but its outer wrapper still reserves space. That leaves a black strip above the player on playlist pages.
The upgrade row in the profile menu also no longer always points directly to
spotify.com/premium; it can use an internal or tracked route, so the old href-based selector misses it.This change:
upgrade.tooltip.title;adblock.jsbundle.Tested manually on Windows with Spotify
1.2.93.667and Spicetify2.44.0: the blank strip is gone on playlist pages and the upgrade entry no longer appears in the profile menu. The generated bundle also passesnode --check.