Fix #142: treat blank API keys in .env as unset#154
Open
evcyen wants to merge 1 commit into
Open
Conversation
evcyen
force-pushed
the
fix/142-blank-api-keys-as-unset
branch
from
c2e62df to
fa9a7f8
Compare
- Normalize any env var ending in _API_KEY (or HF_TOKEN) when value is blank/whitespace - Add tests for blank, whitespace-only, and generic *_API_KEY behavior
evcyen
force-pushed
the
fix/142-blank-api-keys-as-unset
branch
from
fa9a7f8 to
b72c70a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142
When a key is present in
.envbut empty, dotenv sets it to "", so downstream code gets a non-None value and providers raiseAuthenticationError. This change removes any env var whose name ends in_API_KEY(or isHF_TOKEN) when its value is blank or whitespace-only, so “unset” is consistent and new*_API_KEYvars get the same behavior without code changes. Adds tests for blank, whitespace-only, and generic*_API_KEYnormalization.