chore: rust-toolchain.toml (stable) + MSRV 1.88.0#76
Closed
SreeramGarlapati wants to merge 2 commits into
Closed
Conversation
Add rust-toolchain.toml at the workspace root to pin the exact Rust version and required components (clippy, rustfmt). This gives local dev and CI a single source of truth — rustup reads the file automatically, so developers no longer need to manually select a version. CI switches from the dtolnay/rust-toolchain action to `rustup show`, which installs the pinned toolchain and components on the fly from the checked-in file. DEVELOPER.md updated to reference the toolchain file instead of a hardcoded minimum version.
- Change rust-toolchain.toml channel from pinned 1.95.0 to stable - Add rust-version = "1.88.0" to Cargo.toml (floor set by time 0.3.47, darling 0.23.0, serde_with 3.18.0) - rust-toolchain.toml governs local dev + CI components; rust-version in Cargo.toml protects downstream consumers
Collaborator
Author
|
Closing — feedback posted on #68 for munendrasn to update directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #68 — incorporates munendrasn's rust-toolchain.toml work
with review feedback applied.
Summary
rust-toolchain.tomlwithchannel = "stable"and clippy/rustfmt components — single source of truth for local dev and CIrustup showwhich reads the toolchain filerust-version = "1.88.0"toCargo.toml(MSRV floor set bytime 0.3.47,darling 0.23.0,serde_with 3.18.0)DEVELOPER.mdreferences the toolchain file instead of a hardcoded minimumDesign
rust-toolchain.toml(stable) → governs local dev + CI componentsrust-versioninCargo.toml(1.88.0) → protects downstream consumersTest plan
cargo checkpassesrustup showreadingrust-toolchain.toml