chore: upgrade to edition 2024 and resolver 3#80
Draft
munendrasn wants to merge 9 commits into
Draft
Conversation
Add rust-toolchain.toml at the workspace root to pin the exact Rust version and required components (clippy, rustfmt). This gives local dev and CI a single source of truth — rustup reads the file automatically, so developers no longer need to manually select a version. CI switches from the dtolnay/rust-toolchain action to `rustup show`, which installs the pinned toolchain and components on the fly from the checked-in file. DEVELOPER.md updated to reference the toolchain file instead of a hardcoded minimum version.
Edition 2024 (stable since 1.85) aligns with our MSRV 1.88.0 and brings stricter safety defaults — `gen` is now a reserved keyword and implicit borrowing disallows explicit `ref` in patterns. Resolver 3 (stable since 1.84) is MSRV-aware: cargo will avoid pulling dependency versions that require a newer Rust than the workspace rust-version, preventing silent MSRV breakage on update. Code fixes: - Rename `gen` → `generation` in cache.rs and read_path.rs - Remove explicit `ref` in pattern matches in read_path.rs
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen→generation(genis a reserved keyword in 2024)refin pattern matches (disallowed when implicitly borrowing)Why
rust-versionwhen selecting dependency versions, preventing silent MSRV breakage oncargo updateNotes
merutable-pythonhas 17 warnings from PyO3 0.22 macro-generated code hitting edition 2024's stricterunsafe_op_in_unsafe_fnrule — these will be resolved when PyO3 is upgradedTest plan
cargo check --workspacepassescargo test --workspacepasses