Skip to content

Bugfix/s3 utils 239 fix count items bucket logging#394

Open
benzekrimaha wants to merge 3 commits into
development/1.16from
bugfix/S3UTILS-239-fix-count-items-bucket-logging
Open

Bugfix/s3 utils 239 fix count items bucket logging#394
benzekrimaha wants to merge 3 commits into
development/1.16from
bugfix/S3UTILS-239-fix-count-items-bucket-logging

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

@benzekrimaha benzekrimaha commented May 22, 2026

In the PR we are nullifying _bucketLoggingStatus which is safe for count-items specifically: that this metadata is unrelated to object count / storage usage computation and only exists on the BucketInfo object because it is part of the full bucket metadata model.
The implementation we now have is cleaner and makes this explicit by naming the fields as unsupported serialized BucketInfo fields for count-items.
The rationale being that : class-backed fields that count-items does not consume should not be rehydrated in the worker path just to count object metadata.

Issue: S3UTILS-239

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 22, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e May 22, 2026
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 22, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-239 contains:

  • 1.16.7

  • 1.17.11

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.16.8

  • 1.17.12

  • 1.18.0

Please check the Fix Version/s of S3UTILS-239, or the target
branch of this pull request.

@benzekrimaha benzekrimaha requested review from a team, SylvainSenechal and maeldonn May 22, 2026 15:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.29%. Comparing base (86f5889) to head (9d1152a).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.16     #394      +/-   ##
====================================================
+ Coverage             45.23%   45.29%   +0.06%     
====================================================
  Files                    85       85              
  Lines                  6046     6051       +5     
  Branches               1282     1282              
====================================================
+ Hits                   2735     2741       +6     
+ Misses                 3265     3264       -1     
  Partials                 46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread CountItems/CountWorker.js
const { deserializeBigInts, serializeBigInts } = require('./utils/utils');

const PENSIEVE = 'PENSIEVE';
const unsupportedSerializedBucketInfoFields = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could have kept the comment about why we do this 🤔

Copy link
Copy Markdown
Contributor

@maeldonn maeldonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once normalizeBucketInfoForCountItems updated, it will be good for me !

Comment thread CountItems/CountWorker.js
const { deserializeBigInts, serializeBigInts } = require('./utils/utils');

const PENSIEVE = 'PENSIEVE';
const unsupportedSerializedBucketInfoFields = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
const unsupportedSerializedBucketInfoFields = [
const UNSUPPORTED_SERIALIZED_BUCKET_INFO_FIELDS = [

Comment thread CountItems/CountWorker.js
'_websiteConfiguration',
];

function normalizeBucketInfoForCountItems(bucketInfoObj) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using object spread inside a reduce loop creates a brand new copy of the object on every iteration, leading to big time complexity and heavy memory churn. We can optimize this by cloning the object just once and using a for...of loop to safely update the properties.

Suggested change
function normalizeBucketInfoForCountItems(bucketInfoObj) {
function normalizeBucketInfoForCountItems(bucketInfoObj) {
const normalized = { ...bucketInfoObj };
for (const field of unsupportedSerializedBucketInfoFields) {
if (normalized[field]) {
normalized[field] = null;
}
}
return normalized;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants