Skip to content

Adopt timestamp-ordered microVersionId in CRR resync tool#395

Open
maeldonn wants to merge 1 commit into
development/1.17from
improvement/S3UTILS-234/microVersionId
Open

Adopt timestamp-ordered microVersionId in CRR resync tool#395
maeldonn wants to merge 1 commit into
development/1.17from
improvement/S3UTILS-234/microVersionId

Conversation

@maeldonn
Copy link
Copy Markdown
Contributor

Bump arsenal to pick up the new microVersionId format (ts + seq + repGroupId), required by cascaded CRR for loop detection and stale event handling. The resync tool bypasses CloudServer's S3 API, so it generates a random per-instance repGroupId and passes it to updateMicroVersionId() to avoid colliding with concurrent writers.

Issue: S3UTILS-234

@maeldonn maeldonn requested review from a team, SylvainSenechal and delthas May 22, 2026 15:44
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 22, 2026

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 22, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-234 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.17.12

  • 1.18.0

Please check the Fix Version/s of S3UTILS-234, or the target
branch of this pull request.

Bump arsenal to pick up the new microVersionId format
(ts + seq + repGroupId), required by cascaded CRR for loop
detection and stale event handling. The resync tool bypasses
CloudServer's S3 API, so it generates a random per-instance
repGroupId and passes it to updateMicroVersionId() to avoid
colliding with concurrent writers.

Issue: S3UTILS-234
@maeldonn maeldonn force-pushed the improvement/S3UTILS-234/microVersionId branch from 1808039 to 1d860c7 Compare May 22, 2026 15:45
Comment thread package.json
"@smithy/util-retry": "^4.0.7",
"JSONStream": "^1.3.5",
"arsenal": "git+https://github.com/scality/arsenal#8.2.36",
"arsenal": "git+https://github.com/scality/arsenal#improvement/ARSN-578/micro-version-id",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arsenal is pinned to a feature branch (improvement/ARSN-578/micro-version-id) instead of a release tag. Git-based deps must pin to a tag to ensure reproducible builds and avoid picking up unfinished or breaking changes from a moving branch head.

```suggestion
"arsenal": "git+https://github.com/scality/arsenal#",

@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

  • arsenal dependency is pinned to a feature branch instead of a release tag (package.json:36)
    • Pin to the appropriate release tag once the arsenal changes are released, to ensure reproducible builds

Review by Claude Code

Comment thread package.json
"@smithy/util-retry": "^4.0.7",
"JSONStream": "^1.3.5",
"arsenal": "git+https://github.com/scality/arsenal#8.2.36",
"arsenal": "git+https://github.com/scality/arsenal#improvement/ARSN-578/micro-version-id",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`arsenal` is pinned to a feature branch (improvement/ARSN-578/micro-version-id) instead of a release tag. Per project conventions, git-based deps must pin to a tag (like the previous #8.2.36). Branch references are unstable — the resolved commit can change on every install, and the branch may be rebased or deleted. This should be updated to a tagged release of arsenal once the ARSN-578 changes are published.

— Claude Code

@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

  • Dependency pinning: arsenal is pinned to a feature branch (improvement/ARSN-578/micro-version-id) instead of a release tag. All git-based deps (arsenal, vaultclient, bucketclient, werelogs, httpagent) must pin to a tag for reproducible builds.
    • Update to a tagged release once the ARSN-578 changes are published in arsenal.

Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants