refactor(sermant-agentcore): 重构 Nacos 客户端获取 token 逻辑#1802
Closed
wuqiu-ai wants to merge 2 commits into
Closed
Conversation
- 移除对 HttpLoginProcessor 和 NamingHttpClientManager 的依赖 - 直接使用 HTTP POST 请求登录接口获取 token - 优化 token 刷新逻辑，提高代码可读性和可维护性
| * @return response body | ||
| * @throws IOException IO exception during service invocation process | ||
| */ | ||
| private String doPost(String url, Map<String, String> formParams, boolean returnStatusWhenHasError) |
Collaborator
There was a problem hiding this comment.
In What Scenarios Is a StatusCode Return Required When an Invoking Failure Occurs?
hanbingleixue
added
area/framework
Collaborator
|
sign DCO in your commit, you can refer this https://sermant.io/zh/document/community/contributing.html |
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Move lastRefreshTime update to prevent potential exception issues - Use MapUtils.isEmpty() for consistent null and empty checks - Add null check for response entity in error logging - Add missing import for MapUtils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it?
Describe it.
Which issue(s) this PR fixes？
Fixes #
Does this PR introduce a user-facing change?
No
Checklist