fix(calendar): resolve TypeScript error for locale.code access#10716
Open
okxint wants to merge 1 commit into
Open
fix(calendar): resolve TypeScript error for locale.code access#10716okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
DayPickerLocale does not expose a code property at the type level even though the underlying date-fns Locale object carries one at runtime. Add a minimal inline type assertion so TypeScript no longer errors when reading locale?.code in formatMonthDropdown and data-day across all base-* and radix-* calendar variants. Fixes shadcn-ui#10709
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
Contributor
|
@okxint is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
All
base-*andradix-*calendar variants accesslocale?.codein two places:formatMonthDropdownformatter —date.toLocaleString(locale?.code, { month: "short" })data-dayattribute —day.date.toLocaleDateString(locale?.code)The
Localetype re-exported fromreact-day-pickeris typed asDayPickerLocalewhich does not declare acodeproperty, causing a TypeScript error:Property 'code' does not exist on type 'DayPickerLocale'.Fix
Add a minimal inline type assertion
(locale as { code?: string })at both call sites in all 16 affected files. The underlying date-fnsLocaleobject does carrycodeat runtime — only the type was too narrow.No behavior change.
Fixes #10709