fix bug with all caps tokens - #96
Open
chellipse wants to merge 1 commit into
Open
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by kimi-k2.7-code · Input: 34.1K · Output: 6.4K · Cached: 107.5K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously tokens where all letters are uppercase but the string contains chars where
char::is_uppercaseisn't true (ie numbers or w/e) would get scored an incorrectly low variations number by uppercase_variations due to passing a token to n_ck which it isn't designed to score correctly.here are calculated guess numbers for test tokens i used while confirming behavior.
before:
after:
fix was mirrored to uppercase_variations_log10 as well, and a test was added