Skip to content

feat(ui): close resource and Helm drawers by clicking outside #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaviorVirus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui): close resource and Helm drawers by clicking outside #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/k8s-ui/src/components/workload/ResourceDetailDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,19 @@ export function ResourceDetailDrawer({ resource, onClose, onNavigate, initialTab
const headerHeight = headerHeightProp ?? 49

return (
<>
{/* Backdrop — only shown in drawer mode (not expanded), closes on click */}
{!expanded && (
<div
className={clsx(
'fixed inset-0 z-30 transition-opacity duration-300',
isOpen ? 'opacity-100' : 'opacity-0 pointer-events-none',
)}
style={{ top: headerHeight }}
onClick={onClose}
/>
)}

<div
className={clsx(
'fixed right-0 bg-theme-surface border-l border-theme-border flex flex-col shadow-2xl z-40',
Expand Down Expand Up @@ -154,5 +167,6 @@ export function ResourceDetailDrawer({ resource, onClose, onNavigate, initialTab
onCollapseToDrawer: onCollapse ? () => onCollapse() : undefined,
})}
</div>
</>
)
}
12 changes: 12 additions & 0 deletions web/src/components/helm/HelmReleaseDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,17 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
}

return (
<>
{/* Backdrop — closes drawer on click */}
<div
className={clsx(
'fixed inset-0 z-30 transition-opacity duration-300',
isOpen ? 'opacity-100' : 'opacity-0 pointer-events-none',
)}
style={{ top: headerHeight }}
onClick={onClose}
/>

<div
className={clsx(
'fixed right-0 bg-theme-surface border-l border-theme-border flex flex-col shadow-2xl z-40',
Expand Down Expand Up @@ -533,6 +544,7 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
{upgradeProgress.length > 0 && <ProgressLog entries={upgradeProgress} />}
</ConfirmDialog>
</div>
</>
)
}

Expand Down
Loading