Skip to content

fix(ui): accurate topology filter count + Helm chart-name tooltip#825

Merged
nadaverell merged 3 commits into
mainfrom
fix/topology-filter-count-and-chart-name
May 30, 2026
Merged

fix(ui): accurate topology filter count + Helm chart-name tooltip#825
nadaverell merged 3 commits into
mainfrom
fix/topology-filter-count-and-chart-name

Conversation

@nadaverell
Copy link
Copy Markdown
Contributor

@nadaverell nadaverell commented May 29, 2026

Two small, self-contained UX fixes, reimplemented cleanly off current main.

Topology filter footer count

The "Showing N of M resources" footer summed the visible count over the filterable kinds but used nodes.length as the denominator — and nodes.length includes the synthetic Internet node, which isn't a filterable kind. So the two never reconciled, and the count could look wrong / a stale "filtered" state could appear with nothing actually hidden. Both numerator and denominator now come from the filterable kinds, and a · N filtered indicator (with a hover breakdown of which kinds are hidden) is shown only when something is actually filtered out.

Helm chart-name tooltip

Long Helm chart names are truncated in the catalogue with no way to read the full string. Added a native title on the truncated headings so the full name shows on hover — no new dependency, no shared-component change.

Notes

These supersede the salvageable parts of #589 (its topology-footer fix) and #577 (its chart-name hover), reworked from scratch rather than carried over — the count helper is inlined (no separate module) and the chart tooltip uses a native title instead of wrapping the shared Tooltip primitive / adding a tailwind-merge dependency. Verified via /visual-test; make tsc clean.


Note

Low Risk
Display-only UI changes with no auth, data, or API impact.

Overview
Fixes two small UX issues in the topology filter sidebar and Helm chart browser.

The topology “Showing N of M resources” footer now uses the same filterable-kind totals for both numbers (instead of nodes.length, which included the non-filterable synthetic Internet node). When kind filters hide resources, it shows a · N filtered hint and a hover breakdown of hidden kinds.

In ChartBrowser, truncated chart titles in local and ArtifactHub cards are wrapped in the shared Tooltip so the full chart name is readable on hover.

Reviewed by Cursor Bugbot for commit 63564ff. Bugbot is set up for automated code reviews on this repo. Configure here.

- Topology filter sidebar footer: derive both the visible and total counts
  from the filterable kinds. It previously divided the per-kind visible sum
  by nodes.length, which includes the synthetic Internet node, so the two
  never reconciled. Also surface a "· N filtered" indicator with a hover
  breakdown of which kinds are hidden.
- Helm ChartBrowser: add a native title on the truncated chart-name headings
  so the full name is readable on hover.
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4954cf7. Configure here.

Comment thread packages/k8s-ui/src/components/topology/TopologyFilterSidebar.tsx Outdated
Reveal truncated chart names with the shared Tooltip component (theme-
matched, instant) rather than the browser's native title. Non-conflicting
wrapper classes (min-w-0 flex-1 / w-full) keep the truncation working
without overriding the Tooltip's default display, so no tailwind-merge
dependency or shared-primitive change is needed.
@nadaverell nadaverell merged commit 4ebe3fe into main May 30, 2026
9 checks passed
@nadaverell nadaverell deleted the fix/topology-filter-count-and-chart-name branch May 30, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant