Skip to content

fix(mintmaker): always recreate StackRox konflux-tasks update PRs#941

Open
Molter73 wants to merge 1 commit into
mainfrom
mauro/fix/mintmaker-always-recreate-stackrox
Open

fix(mintmaker): always recreate StackRox konflux-tasks update PRs#941
Molter73 wants to merge 1 commit into
mainfrom
mauro/fix/mintmaker-always-recreate-stackrox

Conversation

@Molter73

@Molter73 Molter73 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Recently found some PRs that should've updated the custom konflux tasks from stackrox that were not being set to auto-merge, it has been suggested by the MintMaker team that adding the fields in this PR will help with the issue.

More context at: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1782727458789889

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Can't really test this without merging.

Summary by CodeRabbit

  • Chores
    • Updated the automation configuration to keep package updates more current by automatically recreating and rebasing them when needed.

@Molter73 Molter73 requested a review from a team as a code owner June 29, 2026 13:07
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: bf1833b7-845d-4e13-8369-3a145952c586

📥 Commits

Reviewing files that changed from the base of the PR and between 4a0025e and 527b308.

📒 Files selected for processing (1)
  • .github/renovate.json5

📝 Walkthrough

Walkthrough

Two fields—recreateWhen: "always" and rebaseWhen: "behind-base-branch"—are added to the existing Renovate packageRules entry for quay.io/rhacs-eng/konflux-tasks/ in .github/renovate.json5.

Changes

Renovate Config

Layer / File(s) Summary
Tekton package rule recreation/rebase settings
.github/renovate.json5
Adds recreateWhen: "always" and rebaseWhen: "behind-base-branch" to the Konflux Tasks package rule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops in, config in paw,
"Rebase when behind!" — a sensible law.
Recreate always, keep branches fresh,
No stale PRs caught in the mesh.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: updating MintMaker behavior to always recreate StackRox konflux-tasks update PRs.
Description check ✅ Passed The description explains the change, includes a checklist, and notes testing could not be done without merging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mauro/fix/mintmaker-always-recreate-stackrox

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.23%. Comparing base (4a0025e) to head (527b308).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   32.23%   32.23%           
=======================================
  Files          21       21           
  Lines        2736     2736           
  Branches     2736     2736           
=======================================
  Hits          882      882           
  Misses       1851     1851           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msugakov msugakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really test this without merging.

You can at least run the config validator as described at the beginning of this file. You should see only a couple of errors both regarding something-rpm.

It would be very kind if you could apply the same change to all other repos.

  • collector
  • stackrox
  • scanner
  • operator-index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants