fix(android): forward back key event#13
Open
alexjba wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR forwards the Android Back key from the embedded WebView into the Qt/QML event loop so QML can handle back navigation while the WebView has focus.
Changes:
- Intercept
KEYCODE_BACKin the AndroidWebViewand call a new native callback. - Add a new JNI entry point that posts synthesized Qt
KeyPress/KeyReleaseevents into the app event queue. - Request focus for the
WebViewwhen shown to ensure it receives key events.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mobilewebview/src/android/mobilewebviewbackend_android.cpp | Adds JNI callback to post Qt back-key events to the QQuickWindow. |
| mobilewebview/android/src/org/mobilewebview/MobileWebView.java | Intercepts Android back key in the WebView, forwards to native, and requests focus when visible. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+87
to
+95
| public boolean dispatchKeyEvent(android.view.KeyEvent event) { | ||
| if (event.getKeyCode() == android.view.KeyEvent.KEYCODE_BACK) { | ||
| if (event.getAction() == android.view.KeyEvent.ACTION_UP) { | ||
| withNativePtr(MobileWebView.this::nativeOnBackRequested); | ||
| } | ||
| return true; | ||
| } | ||
| return super.dispatchKeyEvent(event); | ||
| } |
Comment on lines
+88
to
+93
| if (event.getKeyCode() == android.view.KeyEvent.KEYCODE_BACK) { | ||
| if (event.getAction() == android.view.KeyEvent.ACTION_UP) { | ||
| withNativePtr(MobileWebView.this::nativeOnBackRequested); | ||
| } | ||
| return true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push the back key into the application event loop