fix(android): frozen snapshot rendering#14
Conversation
* add/remove clipping for parent fixes status-im/status-app#21051
3d2063a to
aecd4b9
Compare
There was a problem hiding this comment.
Pull request overview
This PR improves Android frozen snapshot rendering by preferring GPU-backed capture and preventing the freeze overlay from stretching after the item is resized.
Changes:
- Adds Android PixelCopy-based freeze snapshot capture with software draw fallback.
- Enables clipping while the freeze overlay is visible and restores prior clip state on unfreeze.
- Stops resizing the freeze overlay on later geometry changes and adds a common backend regression test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mobilewebview/android/src/org/mobilewebview/MobileWebView.java |
Adds PixelCopy snapshot capture path and shared snapshot delivery helpers. |
mobilewebview/src/common/mobilewebviewbackend.cpp |
Enables clipping during freeze, restores clip state, and stops updating overlay size on geometry changes. |
mobilewebview/src/common/mobilewebviewbackend_p.h |
Adds state and helper declaration for freeze clip restoration. |
mobilewebview/tests/tst_mobilewebviewbackend_common.mm |
Adds a regression test for keeping freeze overlay size after resize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* fallback to software rendering * size overlay from captured image dimensions
aecd4b9 to
0bdd6c6
Compare
|
I still think the simplest solution would be to move the webview to the right with the navbar instead of squeezing it. |
Yeah, here is the issue for keeping the navbar open: I think this PR is still useful for disabling stretching in case of other geometry changes, such as on the keyboard display |
freeze2.mp4