fix(android): async webview construction#20916
Merged
friofry merged 1 commit intoMay 18, 2026
Merged
Conversation
friofry
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
friofry
requested review from
Khushboo-dev-cpp and
glitchminer
and removed request for
a team
caybro
approved these changes
May 18, 2026
Member
Jenkins Builds
|
saledjenic
added a commit
that referenced
this pull request
May 21, 2026
* release/2.38.x: (70 commits) fix(NotificationsView): Fix filter exemptions with stable scroll position feat(PushNotifications): Update mobile notification banner display logic feat(notifications): update notification settings copy fix: cliping modal input (#20944) fix(chat): prevent MessageView from stealing ImageMessage right-clicks (#20889) chore(@e2e): temp disable syncing test in release 2.38 fix(android): battery usage while the app is in the background fix(StatusTextField): Use native paste menu for text fields on iOS fix(chat): restore iOS paste menu behavior fix(android): async webview construction (#20916) fix: Community members in community settins fix(Portal): do not autofocus the Search field fix(dapps): dapp name html injection (#20881) fix(nft): disable more chains (#20866) fix: handle shutdown process to avoid race conditions Perf/cherry pick v1 (#20802) emoji/gif/stickers popups sizing ad-hoc patches StatusStickersPopup: layout improved fix: GifPopup and StickersPopup bottom-sheet layout improved Android: workaround for triggering full-screen mode after screenshot ...
saledjenic
added a commit
that referenced
this pull request
May 21, 2026
* Release 2.38.0 * fix(browser): hide sidebar when tapping outside (#20624) * fix: payment modal padding (#20702) fixes #20690 * fix(Browser): open URLs in a new tab from Downloads view Fixes #20685 * fix(RenameAccountModal): responsive layout - fix the overall layout, respecting the modal width - fix the pre-selected color (color vs color-string mismatch) - add the modal to Storybook Fixes #19325 * feat(StatusTextField): provide a standard edit context menu - allows to be styled propely using our Theme - disabled on mobile (iOS/Android provide their own) Fixes #20632 Iterates #20544 * fix(Portal): fix the community promo icon color Fixes #20689 * fix: cannot login via keycard Closes #20633 * chore: remove Polygon zkEVM chain - Deleted constants and UI elements related to Polygon zkEVM from wallet_constants.nim, Constants.qml, and Utils.qml. - Removed SVG icons for Polygon zkEVM from the assets directory. - Updated translation files to eliminate references to Polygon zkEVM Explorer in multiple languages. * chore: display "Unknown token" for tx in History tab if token details are missing For the tokens that are not in any of the list that the app operates with "Unknown token" should be used for the name, and raw value for crypto value instead of the token key. * fix: amount colors of the token breakdown pills make the amounts hard to read Closes #20701 * fix(Settings): fix overflow in Appearance view - add the view to Storybook Fixes #20645 * fix(Desktop) Increasing app height triggers portrait mode - lower the `portraitBreakpoint` to 640x480, and make the portrait/landscape criteria switch depend on `width` only - let the PrimaryNavSidebar follow the same logic - update TS files Fixes #20318 * chore(@e2e): text input * chore(@qml): object name for send button in chat * chore(@e2e): temp exclude password change from PRs * fix: don't try to (re)store window geometry/visiblity on mobile * fix(AppMain): reapply font size and padding when the orientation changes Fixes #20635 * fix(StatusSectionLayout): explicitly state the breakpoint - when switching to portrait mode * fix(main): restore visibility on mobile - similar to setting it to `visible` * fix(browser): android connector fixes (#20623) * fix(browser): stale request when closing connection popup * fix(browser): require webkit 1.12.1 * to enable addDocumentStartJavaScript fixes #20602 * fix(Syncing): Ensure mobile network sync is enabled by default Fixes `syncingOnMobileNetwork` DB value defaulting to false, causing status-go to block store node sync on mobile devices and leaving sent messages stuck in "sending" state. Fixes #20663 * fix(CommunitiesPortal): community cards are cut on the right - simplify the layout, use full width for the ScrollView - remove the internal scaling, causes more issues than it solves - use smaller card delegates when in compact mode - fix some other minor responsive issues - regenerate TS files Fixes #20728 * chore: remove status l2 sepolia (#20748) * ios: upgrade to SDK 26 * fix: avoid sync getAllTokens on every token refresh (#20786) fixes #20784 * fix(StatusChatInfoButton): don't open Profile dialog with pinned message - in 1-1 chats, the TapHandler would leak the click event to the underlying MouseArea, thus invoking both the PinnedMessagesPopup and the ProfileDialog Fixes #20658 * ConfirmationDialog: refactor to derive from StatusDialog * StatusDialog: delayed bindings to ensure proper height in bottom sheet mode * Settings: prevent navigating to settings on sign out request in portrait mode * AdvancdedView: prevent options switching before confirmation * fix(StatusBaseInput): no placeholder with preeditText - also hide the placeholderText when there are suggestions from the native virtual keyboard on mobile Fixes #20774 * fix(browser): android snapshot colors (#20791) * fix(connector): parallel dapp requests race (#20703) * fix(browser): fix crash fixes #20591 * chore: bump status-go * chore: hide data verified by Nimbus (#20811) fixes #20788 * feat(connector): ephemeral dApp records (#20808) * feat(connector): ephemeral dapp records refs #20676 * fix: copilot comments * chore: bump status-go * ChatColumnView: workaround for QTBUG-146653 It was causing that selecting mention from suggestions list was not possible on mobile. Closes: #20798 * StatusChatInputTextArea: take preedit text into account when filtering mentions It's necessary to handle suggestions correctly (filtering based on the user input). Closes: #20743 * StatusChatInputTextArea: take preedit text into account when filtering emojis * fix: swapped ui in history (#20818) Swapped word is now staying in one row * fix(iOS/FileDialog): Use native pickers for image selection Route iOS file selection through native platform pickers to avoid Qt file dialog sizing issues on mobile. - Use `UIDocumentPickerViewController` for document-based flows such as backups and JSON imports. - Add a photo-library mode to `StatusFileDialog` for image selection flows. - Use the native iOS photo picker for profile picture, community logo/banner, and image selector uploads. - Return selected files/photos through the existing `StatusFileDialog` selected file API. - Added support for multi file selection. Closes #20704 * chore: a huge delay between balance/history update (#20812) Closes #20751 * fix(wc): reconnect broken pipe (#20809) * recreate wc client after Resume() fixes #20767 * fix(Search): focus the user/channel/chat search fields - StatusTextField: theme/style according to Status design - SearchBox: derive from StatusTextField instead of the clunky StatusInput; we only need one-line input here anyway - fix usages of the SearchBox, notably fixup the need to use a native validator if needed; greatly simplifies the code to use this component - regenerate TS files Fixes #20754 * chore(@e2e): fix locators for search boxes * chore(@e2e): fix for seed phrase * fix(ThirdpartyServicesPopup): prevent eliding the instructions - use a simple RowLayout with StatusIcon+StatusBaseText, with wrap mode turned on - don't hardcode the InformationTag pill height - remove the redundant Close button Fixes #20706 Fixes #19981 * chore: don't show unknown token for nft name in history view Fixes: #20817 * fix(Onboarding): Make sync pairing page scrollable Make the sync pairing page scrollable so the instructions button stays reachable when the QR scanner content overflows. Fixes #20638 * fix(StatusSectionLayout): Fix SwipeView panel positioning Ensure the portrait `StatusSectionLayout` visually follows `SwipeView.currentIndex` changes on Android by repositioning the internal view after programmatic panel navigation. This prevents the layout from keeping the previous `contentX` while the logical index has already changed. Fix #20771 * Android: workaround for triggering full-screen mode after screenshot On Android 15, taking a screenshot and invoking sharing dialog was triggering full-screen mode, not restored when sharing is finished. Closes: #20612 * fix: GifPopup and StickersPopup bottom-sheet layout improved Closes: #20571 * StatusStickersPopup: layout improved * emoji/gif/stickers popups sizing ad-hoc patches * Perf/cherry pick v1 (#20802) * perf: Async start messenger The startMessenger backend call is a lengthy process, blocking the main thread for a few seconds. Moving it to async tasks gives the main thread the chance advance on the login work until the messenger starts successfully. Perf improvement on my heavy account: Before: 17 sec warm start-up After: 14 sec warm start-up - Added `onMessengerStarted` method to `AccessInterface` to handle messenger start errors. - Implemented `onMessengerStarted` method in `Module` to emit error notifications. - Introduced `SIGNAL_MESSENGER_STARTED` constant for signaling messenger start events. - Created `asyncStartMessengerTask` to manage asynchronous messenger start operations. - Updated `startMessenger` method in `Service` to utilize the new async task and handle responses. * fix: Trim StartMessenger async task output * fix: review coment - remove dead code * perf(qml): Drop the file selectors * fix(webviewLoader): log on error * perf: seed contacts with community members Iterates: #20228 Resolving community members creates a high frequency RPC flood at start-up when the app tries to eagerly resolve every community members. On Android Status community adds around 2 sec in CPU time on warm start-up. The solution implements an enriched community member type and contact type returned from status-go. The app will receive this extra data and seed the contacts cache (instead of creating the contacts cache using 4 separate RPCs for each member/contact). * perf: enhance contact seeding with MemberSeed structure and optimize duplicate handling * feat: Migrate android binder from files to shared memory This commit aligns the client-server communication with standard Android solutions - direct binder calls and shared memory. This is done both for perf reasons (has a big impact on high frequency callse) and security concerns (no unencrypted data is touching the disk). There are two main changes in this commit: 1. Direct communication between client and service when the payload is below 64KB. This is for high frequency and ligh calls (like colorId). The file based communication overhead is just too high for such usage. 2. Shared memory - When the payload is bigger than 64KB we'll use the shared memory * perf: Avoid unnecessary community and chat copies The nim profile trace is dominated with community and chat object copies. There are 3 main types of changes: - using `lent` to borrow a community from the service. It can be used as a return type only - using openarray in favor of seq for proc args, where `lent` cannot be used. - use "communityId" instead of full community where openarray or lent migration would cascade into lots of changes * perf: Optimize community role retrieval in getChatItemFromChatDto * perf: Move `getCachedCurrencyFormats` to threadpool * fix: Fixing merge errors * perf: Granular control qml compilation and loading of main layouts This commit aims to split the qml compilation into smaller chunks and schedule the compilation at the appropriate time. Approach: Each main section lives behind a loader component that has 2 purposes - load the component at appropriate times and defer the qml compilation until the loader is created. The same approach was applied to AppMain.qml and on top of this we'll need to make sure we're loading the AppMain at an appropriate time so that we'll avoid many intermediary states if the nim layer isn't ready for it. For this, I've introduced a new component - QmlCompiler. It has a list of main components and can precompile the qml component or make sure to load it all if needed (e.g while the onboarding runs we can use that time to preload everything) This approach is fully compatible with Loader.asynchronous usage and implementing loading states for the components - the community and chat loaders already implement it partially. Can be extended to preload all the sections in the background while the user is working on the current section. - Added MarketLoader.qml to handle market-related UI loading. - Introduced NodeLoader.qml for loading node-related UI components. - Created PopupsLoader.qml to manage various popups within the application. - Developed ProfileLoader.qml for loading user profile sections. - Implemented WalletLoader.qml to manage wallet-related UI components. - Added QmlCompiler.qml to centralize URL management for QML components. - Updated qmldir to include new loaders for better modularity. - Refactored main.qml to utilize the new AppMainLoader and improve loading logic. * fix: Correct spelling, function args and bindings * chore: bump vendors * fix: home selection doesn't open the proper 1x1 chat There are 2 bugs: property binding override from within the component internals and a signal signature mismatch * fix: handle shutdown process to avoid race conditions - Added a custom exit procedure (https://en.cppreference.com/c/program/_Exit) to bypass libc static destructors on mobile devices, preventing potential race conditions during shutdown - Ensured proper teardown of the threadpool in the StatusFoundation delete method Fixes #20855 * fix(nft): disable more chains (#20866) * fix(collectibles): add ink, katana to unsupported list fixes #20717 * fix(dapps): dapp name html injection (#20881) * chore: add dapp fields html injection to storybook * fix(dapps): use the PlainText format for dApp controlled strings fixes #20879 * fix(Portal): do not autofocus the Search field Fixes #20870 * fix: Community members in community settins * fix(android): async webview construction (#20916) fixes #20886 * fix(chat): restore iOS paste menu behavior Use the platform popup for the chat input context menu on iOS so paste and selection actions follow native text editing behavior. Avoid toggling readOnly during iOS paste handling, since that dismisses and restores the virtual keyboard. Keep Android using the existing null context menu path. Closes #20588 * fix(StatusTextField): Use native paste menu for text fields on iOS Use the native iOS context menu for StatusTextField and keep Android on the default behavior. * fix(android): battery usage while the app is in the background This commit bumps status-go to include status-im/status-go#7440. As a result the message sending is paused while in the background to stop the high frequency mvds loops that will prevent Android from going into sleep. To preserve message sending while the app is in the background/killed we'll have to wake messenger briefly on the OS intent. We'll resume messenger for 60 seconds - enough to push the message through and then it will be paused again unless the app goes back to foreground. This results in less battery usage and less events piling up in the qt event loop while the app is in the background. * chore(@e2e): temp disable syncing test in release 2.38 * fix(chat): prevent MessageView from stealing ImageMessage right-clicks (#20889) fixes #20789 * fix: cliping modal input (#20944) * feat(notifications): update notification settings copy Refresh notification settings wording across desktop and mobile, renaming the settings entry to “Notifications” and updating the enable notifications popup copy for iOS and other platforms. Add clearer privacy messaging for APNs, on-device mobile delivery, and desktop OS notifications. Restore the iOS centralized notification options section and reuse the sound/volume controls across general and iOS notification settings, while keeping platform-specific test notification behavior. Part of #20628 * feat(PushNotifications): Update mobile notification banner display logic Adds local display state for the mobile push notification banner so it can respect the “Don’t ask me again” choice and avoid reappearing within the same minor version. The banner is now shown only on mobile when private notifications are disabled, the current app minor version is at least 2.38, the user has not opted out, and the banner has not already been shown for that minor version. Patch updates reuse the same stored minor version, so they do not retrigger the banner. Also wires the current app version into the handler and adds the “Don’t ask me again” switch to the popup. Closes #20902 * fix(NotificationsView): Fix filter exemptions with stable scroll position Move exemption search filtering from delegate visibility toggles to a SortFilterProxyModel, so the list only instantiates matching items instead of hiding non-matching delegates. Keep the exemptions list height stable while filtering, capped to the visible settings page height, to avoid the page scroll jumping when the filtered result count shrinks without leaving a long empty scroll area. * fix: failed e2e test fixed * chore(@e2e): fix after conflicts resolution --------- Co-authored-by: Anthony Laibe <491074+alaibe@users.noreply.github.com> Co-authored-by: Andrey Bocharnikov <andrey.bocharnikov@gmail.com> Co-authored-by: Lukáš Tinkl <lukast@status.im> Co-authored-by: Anastasiya <anastasija.ig@gmail.com> Co-authored-by: Noelia <noelia@status.im> Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> Co-authored-by: Michał Cieślak <michalcieslak@status.im> Co-authored-by: Alex Jbanca <47811206+alexjba@users.noreply.github.com> Co-authored-by: Alex Jbanca <alexjb@status.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integrate fix: status-im/mobilewebview#10
webview-async2.mp4
fixes #20886