Skip to content

Typo: unnecessary uppercase in "Bicycle boulevard"#6840

Open
etienne-s wants to merge 1 commit into
streetcomplete:masterfrom
etienne-s:bicycle_boulevard
Open

Typo: unnecessary uppercase in "Bicycle boulevard"#6840
etienne-s wants to merge 1 commit into
streetcomplete:masterfrom
etienne-s:bicycle_boulevard

Conversation

@etienne-s
Copy link
Copy Markdown

I'd just like to fix this typo. Not sure whether I should also update the strings.xml in commonMain/ ?

Screenshot_20260505-012551

@matkoniecz
Copy link
Copy Markdown
Member

this file has

app/src/androidMain/res/values/strings.xml is the source file for the app’s strings in en-US.

so I expect that changing it should be fine (if not then comment should be updated)

Copy link
Copy Markdown
Member

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though note: I have not actually tested it, only looked at code

@westnordost
Copy link
Copy Markdown
Member

No, actually, the strings.xml in commonMain is the source.

But, note that the string you changed is also used somewhere else. And there it makes sense that it is uppercased.

@etienne-s
Copy link
Copy Markdown
Author

I see. Shall I close this PR then? It's a very minor issue anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants