Typo: unnecessary uppercase in "Bicycle boulevard"#6840
Open
etienne-s wants to merge 1 commit into
Open
Conversation
Member
|
this file has
so I expect that changing it should be fine (if not then comment should be updated) |
matkoniecz
approved these changes
May 5, 2026
Member
|
No, actually, the strings.xml in commonMain is the source. But, note that the string you changed is also used somewhere else. And there it makes sense that it is uppercased. |
Author
|
I see. Shall I close this PR then? It's a very minor issue anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd just like to fix this typo. Not sure whether I should also update the strings.xml in commonMain/ ?