Adjust display of data with long strings and emojis#1139
Open
ofsound wants to merge 12 commits into
Open
Conversation
…track titles in Accordions
…elow the tracks in proper style
…reen and long track name
…id uneven columns
ofsound
marked this pull request as ready for review
September 28, 2021 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this resolves any of our official issues!!
Mainly it addresses some overflow bugs with emoji characters that are taller than any of a font's regular characters, in accordions and in the mini "listens" module.
It also fixes a few cases of when a very long artist name would take up 2 vertical lines in areas where the design didn't intend for that to happen.
I also added some horizontal padding in a few places I had noticed where a long artist name could push a field to be 100% and inappropriately extend to the very edge of its container.
"Ready For Review" checklist
These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.
Before code review and after additional commits during review.