Fix browser executablePath config ignored in gateway mode#32
Open
lucaslorentz wants to merge 1 commit into
Open
Fix browser executablePath config ignored in gateway mode#32lucaslorentz wants to merge 1 commit into
lucaslorentz wants to merge 1 commit into
Conversation
|
@lucaslorentz is attempting to deploy a commit to the DevApe Team on Vercel. A member of the Team first needs to authorize it. |
setBrowserConfig() was only called in mcp-stdio-server.ts but not in gateway/server.ts, so browser.executablePath from config was silently ignored when running via the Electron app. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lucaslorentz
force-pushed
the
fix/browser-config-gateway
branch
3 times, most recently
from
April 1, 2026 18:03
5d38d36 to
7e0ba04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running via the Electron app (gateway mode),
browser.executablePathfrom~/.dorabot/config.jsonis ignored becausesetBrowserConfig()is never called ingateway/server.ts. It's only called inmcp-stdio-server.ts.This means users who configure a custom browser (e.g. Chromium instead of Chrome) always get the first system browser found by
findChromium(), which defaults to Google Chrome.Use case: On macOS, running Chrome for both the user and dorabot causes profile conflicts (only one Chrome.app process can run at a time). Setting
executablePathto Chromium solves this, but the config was silently ignored in gateway mode.Fix: Add the missing
setBrowserConfig(config.browser || {})call instartGateway(), matching the existing pattern used forsetScheduler().