Skip to content

fix: update marker on font change#3596

Open
VladaHarbour wants to merge 4 commits into
mainfrom
sd-3238_update-marker-font
Open

fix: update marker on font change#3596
VladaHarbour wants to merge 4 commits into
mainfrom
sd-3238_update-marker-font

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

No description provided.

@VladaHarbour VladaHarbour self-assigned this Jun 1, 2026
@VladaHarbour VladaHarbour requested a review from a team as a code owner June 1, 2026 18:45
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Jun 1, 2026

SD-3238

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cfbdb4ca7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/super-editor/src/editors/v1/core/layout-adapter/list-marker-font.ts Outdated
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

2 issues found across 4 files

Linked issue analysis

Linked issue: SD-3238: Bug: Existing list markers do not restyle after changing font family or size

Status Acceptance criteria Notes
Existing list markers restyle immediately when the user changes font family on an existing list selection. The new syncListMarkerFontFromParagraphRuns copies resolved run/paragraph fontFamily into the marker run (unless numbering explicitly defines the marker family). A behavior test was added that selects an ordered list, sets fontFamily to Georgia, and asserts the marker's computed fontFamily contains Georgia.
Existing list markers restyle immediately when the user changes font size on an existing list selection. The sync logic also updates markerRun.fontSize from paragraph/run fontSize. A behavior test was added that changes font size on a bullet list and asserts the marker's computed fontSize increased accordingly.
Marker restyling applies consistently for both bulleted and numbered lists. Behavior tests include assertions for both ordered (numbered) and bullet lists. Unit tests also include a Symbol/font-family scenario and preserve numbering-defined marker font family while syncing size, covering both marker types and numbering-defined fonts.
The behavior is covered by automated tests that would fail on the current implementation. A dedicated unit test file and updated behavior tests were added to assert the new marker restyling behavior; these tests encode the expected outcomes described in the issue.
The fix does not regress the existing behavior where newly created list items inherit the surrounding list font styling. The behavior test asserting that a newly created empty list item inherits the previous paragraph's font was preserved and updated; the sync implementation preserves numbering-defined fontFamily and only overrides when appropriate, and the integration calls occur in paragraph conversion/handling to avoid breaking inheritance.

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@VladaHarbour VladaHarbour force-pushed the sd-3238_update-marker-font branch from cd68e21 to 10b9bec Compare June 2, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants