Release for katello 5.0#19
Conversation
Odilhao
force-pushed
the
release-for-katello-5.0
branch
from
69444f3 to
60d3af1
Compare
| gem 'minitest', '5.18' | ||
| gem 'minitest-spec-context' | ||
| gem 'mocha' | ||
| gem 'mocha', '~> 2.1.0' |
There was a problem hiding this comment.
in the gemspec, mocha is already pinned to ~> 2.0, why is it required here again?
There was a problem hiding this comment.
probably not something we need to fix in this PR, but declaring things twice seems like a source of trouble
There was a problem hiding this comment.
but we should pin to ~> 2.0 as I think ParameterMatchers::Base was only removed in 3.0, not 2.2
There was a problem hiding this comment.
| gem 'mocha', '~> 2.1.0' | |
| gem 'mocha', '~> 2.0' |
let's see what CI thinks
There was a problem hiding this comment.
As expected, this passed with 2.8.2, what was Claude "thinking"?!
There was a problem hiding this comment.
Also unpinning it in hammer-cli-foreman: theforeman/hammer-cli-foreman#654
Mocha 3.0+ removed ParameterMatchers::Base which is used by hammer_cli_foreman, causing test failures across all Ruby versions. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-Authored-By: Evgeni Golov <evgeni@golov.de>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
evgeni
force-pushed
the
release-for-katello-5.0
branch
from
87c9d9e to
d4c4113
Compare
|
Thanks @evgeni Do you have permission to cut the release? |
|
NVM it's published |
2 participants
No description provided.