change condition to generate recursion ACL#294
Open
ikonia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently the toggle for enable recursion $dns::recursion: is separate from the acl to allow access to recursion $dns::allow_recursion, the module defaults to $dns::allow_recursion ['localnets', 'localhost'],
This means that even with $dns::recursion: no, the allow_recursion ACL will still be generated in options.conf.
previous versions of named this didn't matter as if $dns::recursion: no (which generates "recursion no;" in the named.conf overrides any reference to recursion (making the ACL generated by $dns::allow_recursion ignored.
In later versions of bind this behaviour has been deprecated where now configuration validation fails if recursion is disabled but an ACL for recursion is defined.
This could be resolved in the module by overriding $dns::allow_recursion to null, or defaulting it to null and forcing the user to set if it desired.
I believe that a better logic is in this MR where if recursion is disabled the code block is ignored and the recursion ACL is not generated at all, and leaving the default for $dns::allow_recursion to safe defaults of localhost and localnet which an administrator can then override if desired