allow ACLS to be used in zone configuration options#295
Open
ikonia wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
I believe this will also fix #164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--- suggested approach drop if a bad idea ----
being able to use ACLS' in zone definition such as allow-updates, allow-query, allow-tranfer is limited to internally defined ACLS (localnets and localhost) this maybe enough for a lot of use cases, but as ACL's and views become more important the ability to use ACLS within these parameters is important.
in order to use the ACL definition within puppet-dns the ACL's must be move higher up the template so they are available to be used in the zone definition.
this creates another problem that the validate process validates against temporary files from concat which means it will never pass validation because the required files it depends on are not generated at this point, until there is a better way to validate the ACL's it seems logical to remove validation on ACLS'