Fix uninstall dry-run leftover warnings#923
Merged
Merged
Conversation
M-Hassan-Raza
force-pushed
the
fix/uninstall-dry-run-leftovers
branch
from
f89869e to
ca4523b
Compare
Owner
|
@M-Hassan-Raza Thanks for the focused dry-run fix and regression test. Merged into main. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mo uninstall --dry-run was leaving files in place like it should, then checking those same files and printing Could not remove.
that made a preview look like a failed uninstall.
this skips that leftover check only in dry-run. real uninstall still reports leftovers.
tested with bats tests/uninstall.bats, ./scripts/check.sh --no-format, ./scripts/test.sh, make build