WiP: switch e.g. html/javascript template strings with embedded escape codes to raw string - #395
Draft
jonasbardino wants to merge 10 commits into
Draft
Conversation
jonasbardino
added
the
WiP
jonasbardino
added this to the
Python3 support for general research data sites milestone
…scapes in them to raw strings in order to avoid DeprecationWarning (on python3.6+) or SyntaxError (python3.12+).
jonasbardino
force-pushed
the
fix/invalid-escape-sequences-in-strings-with-explicit-raw-strings
branch
from
July 17, 2026 12:34
0fcccff to
5d7a987
Compare
…rings to avoid DeprecationWarning or SyntaxError when running our code or the unit tests with recent python versions. Now `make unittest` completes without such issues. There may be additional cases lurking in parts of the code simply not covered by unittests yet.
…s are used. Now checking with `bandit -v -r mig/shared|grep 'invalid escape sequence'` only reports an invalid escaped '\S' in the ancient `forum.py` helper which is scheduled for retirement.
…s are used in `mig/server/` as well . Now checking with `bandit -v -r mig/|grep 'invalid escape sequence'` only reports an invalid escaped '\S' in the ancient `forum.py` helper which is scheduled for retirement. Reimplemented the dead-ugly conditional print in `print_on_error` in an attempt to prevent any future readers from going insane.
Contributor
Author
|
The final remaining lint error is a duplicate of the old one from #338. |
…eparate future branch. It is also necessary to introduce the now mandatory parenteses currently missing in the old (py2) print statements.
…leaving out the complex escaping to completely remove the need for r-strings there. Further updates may be needed there as well in the future task to fix the py2'isms like `print "bla"` without parentheses in the python version.
… and explicitly check that the r-string modification doesn't change anything. I tested with and without the r-string change enabled to confirm.
jonasbardino
added a commit
that referenced
this pull request
Jul 21, 2026
…s visited in #395 to help verify correctness there. Rework the functionality backend `main` functions to follow the wrapping used in `datatransfer` and its tests. Not optimal but needed unless we reimplement `main` everywhere :-/ Exposed `path_info` arg in the shared `create_http_environ` helper in order to let other helpers extract the active backend from that field in env when used. Added missing check for enabled workflows in vgridworkflows and adjusted to make sure the title dictionary it appends to has the expected 'advanced', 'init' and 'ready' fields. Automatic style polish from editor and autopep8 in some locations.
jonasbardino
added
the
stale check errors
jonasbardino
added a commit
that referenced
this pull request
Jul 30, 2026
…olish (#609) * Address a few lint errors including the one highlighted in #395 and polish to be more robust even if an invalid path type is given. * Address review feedback (thanks @Martin-Rehr): Reworked handling of missing paths to avoid corner-case changes of logic and warn about unsupported type answers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch e.g. html/javascript template strings with embedded escapes in them to raw strings like
r"bla\*" in order to avoidDeprecationWarning(on python3.6+) orSyntaxError` (python3.12+).Tools like
banditwill warn about the existence of such strings when scanned so it can be used to locate all relevant occurrences in our code base.It's important to validate that the raw string wrapping does not change the meaning of the code. They typically remove the need for one level of escaping as in
Integrates #609 to prevent the corresponding old lint errors in existing code. So it's best to merge that one first.
Still pending some verification that none of the updates actually change the resulting strings. Manually verified for
server/*.pyandshared/functionality/*.pymodules so far.We should add unit tests to verify the correct output of the individual functions or the entire page. Since it overlaps with #612, #613 and #614 it may be best to merge those first and rebase here.