Skip to content

Simplify and aligin shellexec debug and error messages #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martin-Rehr merged 1 commit into from
Jul 3, 2026
Merged

Simplify and aligin shellexec debug and error messages #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mig/lib/lustrequota.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
#
Expand Down Expand Up @@ -151,13 +151,13 @@
stderr = force_unicode(stderr)
if result == 0:
logger.debug(
"%s %s: rc: %s, stdout: %s, error: %s"
% (command, " ".join(__args), rc, stdout, stderr)
"%s: rc: %s, stdout: %s, error: %s"
% (" ".join(__args), rc, stdout, stderr)
)
else:
logger.error(
"shellexec: %s %s: rc: %s, stdout: %s, error: %s"
% (command, " ".join(__args), rc, stdout, stderr)
"shellexec: %s: rc: %s, stdout: %s, error: %s"
% (" ".join(__args), rc, stdout, stderr)
)

return (rc, stdout, stderr)
Expand Down Expand Up @@ -223,7 +223,7 @@
)
return -1

# Dump lustre projid in quota_datapath and wait for it to appear in the quota

Check warning on line 226 in mig/lib/lustrequota.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

line too long (81 > 80 characters)
# NOTE: Written to the original data_basepath to ensure that it goes through
# encryption in the 'lustre-gocryptfs' scenario
# NOTE: Left for lustre projid tracing, may be deleted in the future
Expand Down Expand Up @@ -543,7 +543,7 @@
return True


def update_lustre_quota(configuration):

Check failure on line 546 in mig/lib/lustrequota.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

unused function 'update_lustre_quota' (60% confidence)
"""Update lustre quota for users and vgrids"""
logger = configuration.logger

Expand Down Expand Up @@ -640,7 +640,7 @@
owners_filepath = os.path.join(vgrid_dirpath, "owners")
if os.path.isfile(owners_filepath):
vgrid = vgrid_flat_name(
vgrid_dirpath[len(configuration.vgrid_home) :],

Check warning on line 643 in mig/lib/lustrequota.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

whitespace before ':'
configuration,
)
logger.debug("Found vgrid: %r" % vgrid)
Expand Down
Loading